Skip to content

feat(docker): add nodes config build arg for custom workers#488

Merged
eliteprox merged 13 commits intomainfrom
feat/custom-nodes-config
Dec 29, 2025
Merged

feat(docker): add nodes config build arg for custom workers#488
eliteprox merged 13 commits intomainfrom
feat/custom-nodes-config

Conversation

@eliteprox
Copy link
Collaborator

@eliteprox eliteprox commented Oct 31, 2025 •
edited
Loading

This PR adds a NODES_CONFIG build arg to Dockerfile.base to enable ComfyStream BYOC worker builds targeting different sets of custom nodes. A new --config flag was added to setup_nodes.py and setup_models.py to configure the environment

The feature is used to implement ComfyUI-StreamDiffusion using configs/nodes-streamdiffusion.yaml

Build with custom config from configs directory

base image

docker build -f docker/Dockerfile.base \
  --build-arg NODES_CONFIG=nodes-streamdiffusion.yaml \
  -t livepeer/comfyui-base:streamdiffusion .

comfystream image

docker build -f docker/Dockerfile \
 --build-arg BASE_IMAGE=livepeer/comfyui-base:streamdiffusion  \
  -t livepeer/comfystream:streamdiffusion .

@eliteprox eliteprox linked an issue Nov 3, 2025 that may be closed by this pull request
Ability to ship Comfystream build with limited node set #417
Closed
This was referenced Nov 17, 2025
Closed
Closed
This was linked to issues Nov 25, 2025
Validate SDXL with Streamdiffusion Porting to Comfy Node #476
Closed
Update standalone build trt scripts in ComfyUI-Streamdiffusion #479
Closed
Ship ComfyStream built with ComfyUI-StreamDiffusion #501
Closed
@eliteprox eliteprox linked an issue Dec 8, 2025 that may be closed by this pull request
Integrate StreamDiffusion Engine Compilation in ComfyStream #514
Closed
@eliteprox eliteprox mentioned this pull request Dec 8, 2025
Closed
@eliteprox eliteprox marked this pull request as ready for review December 8, 2025 22:51
@eliteprox eliteprox marked this pull request as draft December 8, 2025 22:54
@eliteprox eliteprox changed the title feat(docker): add nodes config build arg for workflow dispatch feat(docker): add nodes config build arg for custom workers Dec 9, 2025
@eliteprox eliteprox force-pushed the feat/custom-nodes-config branch from 425fa28 to 049c950 Compare December 18, 2025 18:58
@eliteprox
Copy link
Collaborator Author

eliteprox commented Dec 18, 2025

Changes need testing as built docker container running as a server. Model downloads and engine builds should go to the paths expected by the example ComfyUI workflow. Example workflow to be added

eliteprox
eliteprox commented Dec 18, 2025
View reviewed changes
configs/models-ipadapter.yaml

PixelArtRedmond15V-PixelArt-PIXARFK.safetensors:
name: "PixelArtRedmond15V-PixelArt-PIXARFK"
url: "https://huggingface.co/artificialguybr/pixelartredmond-1-5v-pixel-art-loras-for-sd-1-5/resolve/ab43d9e2cf8c9240189f01e9cdc4ca341362500c/PixelArtRedmond15V-PixelArt-PIXARFK.safetensors"
Copy link
Collaborator Author

@eliteprox eliteprox Dec 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Models download uses PixelArtRedmond15V-PixelArt-PIXARFK.safetensors, but example workflow uses PixelArt.safetensors

@eliteprox eliteprox marked this pull request as ready for review December 18, 2025 19:43
@eliteprox
Copy link
Collaborator Author

eliteprox commented Dec 18, 2025

Engine builds are needed in entrypoint.sh. Parameters should match with the suggested example workflow, which should also be added.

@RUFFY-369 RUFFY-369 self-assigned this Dec 18, 2025
@RUFFY-369 RUFFY-369 mentioned this pull request Dec 19, 2025
Merged
@eliteprox
Copy link
Collaborator Author

eliteprox commented Dec 22, 2025 •
edited
Loading

@RUFFY-369 We might need to find a way to link nodes and model/engine configs since. --build-engines fails currently when built as a default container (nodes.yaml)

Engine for DepthAnything2 (large) already exists at /workspace/ComfyUI/models/tensorrt/depth-anything/depth_anything_v2_vitl-fp16.engine, skipping...
Engines for FasterLivePortrait already exists, skipping...
Building StreamDiffusion TensorRT engines using config: /workspace/ComfyUI/custom_nodes/ComfyUI-StreamDiffusion/configs/sd15_singlecontrol.yaml
python: can't open file '/workspace/ComfyUI/custom_nodes/ComfyUI-StreamDiffusion/scripts/build_tensorrt_engines.py': [Errno 2] No such file or directory
elite@elite4:~$

@RUFFY-369 RUFFY-369 mentioned this pull request Dec 26, 2025
Merged
@eliteprox eliteprox requested a review from RUFFY-369 December 26, 2025 20:57
eliteprox
eliteprox commented Dec 29, 2025
View reviewed changes
.devcontainer/devcontainer.json
// Commented out to use the build context instead
// TODO: Update this to the correct image name
// when using images other than livepeer/comfystream:latest
// "image": "livepeer/comfystream:streamdiffusion",
Copy link
Collaborator Author

@eliteprox eliteprox Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated with comments here to allow for quick editing to test images other than livepeer/comfyui-base:latest

This was needed because devcontainer build failed with livepeer/comfyui-base:streamdiffusion as the BASE_IMAGE name.

RUFFY-369
RUFFY-369 approved these changes Dec 29, 2025
View reviewed changes
Copy link

@RUFFY-369 RUFFY-369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eliteprox eliteprox merged commit ea80d3f into main Dec 29, 2025
5 of 6 checks passed
@eliteprox eliteprox deleted the feat/custom-nodes-config branch December 29, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RUFFY-369 RUFFY-369 RUFFY-369 approved these changes

Assignees

@RUFFY-369 RUFFY-369

Labels

None yet

Projects

None yet

Milestone

No milestone

2 participants

@eliteprox @RUFFY-369